Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle encrypted pinned messages #32380

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented May 7, 2024

Proposed changes (including videos or screenshots)

Decrypt encrypted pinned messages in E2EE channels.
Introducing a new message type - message_pinned_e2e for encrypted pinned messages. The messages with this type will be decrypted before being shown.

image

Issue(s)

Steps to test or reproduce

  • Create an encrypted channel
  • Send some message and pin it
  • The pinned message in chat looks like gibberish
  • The message in pinned messages tab isn't shown

Further comments

E2EE-14

Copy link
Contributor

dionisio-bot bot commented May 7, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 092574e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/core-typings Patch
@rocket.chat/meteor Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal marked this pull request as ready for review May 7, 2024 12:32
@yash-rajpal yash-rajpal requested review from a team as code owners May 7, 2024 12:32
@yash-rajpal yash-rajpal added this to the 6.9 milestone May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 55.51%. Comparing base (ff4e396) to head (d6e8d26).
Report is 55 commits behind head on develop.

Current head d6e8d26 differs from pull request most recent head 092574e

Please upload reports for the commit 092574e to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32380      +/-   ##
===========================================
- Coverage    55.59%   55.51%   -0.09%     
===========================================
  Files         2407     2403       -4     
  Lines        52905    52871      -34     
  Branches     10866    10864       -2     
===========================================
- Hits         29415    29353      -62     
- Misses       20886    20906      +20     
- Partials      2604     2612       +8     
Flag Coverage Δ
e2e 54.74% <12.50%> (-0.14%) ⬇️
unit 73.53% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

.changeset/forty-bikes-check.md Outdated Show resolved Hide resolved
apps/meteor/app/e2e/client/rocketchat.e2e.ts Outdated Show resolved Hide resolved
apps/meteor/app/e2e/client/rocketchat.e2e.ts Outdated Show resolved Hide resolved
apps/meteor/app/e2e/client/rocketchat.e2e.ts Show resolved Hide resolved
apps/meteor/client/components/message/StatusIndicators.tsx Outdated Show resolved Hide resolved
apps/meteor/client/startup/e2e.ts Outdated Show resolved Hide resolved
@scuciatto scuciatto removed this from the 6.9 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants