feat: Add LDAP group validation strategy setting to channels and roles sync

[matheusbsilva137]

Proposed changes (including videos or screenshots)

• Added "Group membership validation strategy" settings to "Sync Channels" and "Sync Roles" LDAP sections -- they may enable a faster sync process when combined with a good LDAP search filter;

Available strategies:

• Apply filter for each group: apply the LDAP user group filter for each group (key) defined in the LDAP group channel map. This is slower, but can be useful in case you need to use the #{groupName} replacement tag to define membership (e.g. when filtering by the memberOf field in groups);
• Apply filter once to get all memberships: apply the LDAP user group filter once for each user. A given user will be considered a member of all groups returned by the LDAP search. This is a faster option that can be applied in case the #{groupName} replacement tag is not used by the filter (e.g. when filtering by the member field in groups).

Issue(s)

Steps to test or reproduce

The new "Group membership validation strategy" setting is available under both "Sync Channels" and "Sync Roles" sections in LDAP Premium settings. Both features should work just the same as in previous version when using the default "Apply filter for each group" search strategy or the new and faster "Apply filter once to get all memberships" strategy -- the only difference here is the amount of LDAP search requests triggered by RC.

Sample configuration

Sample configuration for using the "Apply filter once to get all memberships" search strategy:

Sample configuration for using the "Apply filter for each group" search strategy:

Caution

Switching to the new and faster "Apply filter once to get all memberships" search strategy may not work with the currently configured LDAP search filter!
When switching to the new strategy, make sure to update the user group filter so as to get all groups at once in a single query with it (be sure not to use the #{groupName} replacement tag since it is not supported by this new strategy)

Further comments

CORE-402

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 7da85e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/i18n	Minor
@rocket.chat/mock-providers	Patch
@rocket.chat/ui-contexts	Major
@rocket.chat/web-ui-registration	Major
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/ui-client	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/core-typings	Minor
@rocket.chat/rest-typings	Minor
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.84%. Comparing base (3cbbecd) to head (7da85e4).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32436      +/-   ##
===========================================
- Coverage    55.84%   55.84%   -0.01%     
===========================================
  Files         2432     2432              
  Lines        53480    53480              
  Branches     10993    10993              
===========================================
- Hits         29868    29864       -4     
- Misses       20973    20979       +6     
+ Partials      2639     2637       -2     

Flag	Coverage Δ
e2e	55.18% <ø> (+<0.01%)	⬆️
e2e-api	41.13% <ø> (-0.04%)	⬇️
unit	72.72% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[pierre-lehnen-rc]

The PR should still be flagged as a breaking change since it'll no longer be possible to use both strategies at the same time.

There should also be a migration to select the right strategy automatically if only one of them is currently being used.

Ignore this review, I see now that the PR is making a different change than the one we had discussed last time.