Platform Device improvements and Timer abstraction #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, platform device holds only a pointer, which is safe to be used from any thread. This is useful for devices that are not probed, such as virtual devices. Signed-off-by: Maíra Canal <mcanal@igalia.com>
Allows drivers to directly allocate and register a device. Although this style of driver is discouraged, it is useful for virtual devices that cannot be probed. Also, handles the deallocation of a registered device through the Drop trait. Signed-off-by: Maíra Canal <mcanal@igalia.com>
Allows drivers to configure the DMA masks for a device, dealing with the case where the device does not have dev->dma_mask appropriately setup. Implemented here, not in device, because it requires a mutable platform device reference. Signed-off-by: Maíra Canal <mcanal@igalia.com>
Create an abstraction to allow Rust drivers to open a new devres group for the device with a defined id. Moreover, implement the related Drop trait to release the devres group. Signed-off-by: Maíra Canal <mcanal@igalia.com>
Timers are used in the kernel to allow drivers to call callbacks after a given time. So, add an abstraction to allow Rust drivers to interact with this subsystem. Signed-off-by: Maíra Canal <mcanal@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
This PR is a collection of some abstractions that I wrote while developing the VGEM driver in Rust. So, they are dependencies of the driver itself. The complete driver can be seen in this PR, which is rebased on top of Lina's DRM abstractions branch. Also, there is a blog post describing a bit more of the idea of the project.
Unfortunately, this PR cannot be rebased on top of rust-next, because it depends on the Platform Device abstraction. As this is my first time writing safe abstractions, I would like to hear your feedback on the abstractions, especially the Timer abstraction.
Thanks for your attention!