added tm_gmtoff and tm_zone attributes to PyStructTime #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
reviewed
Jun 20, 2023
| @@ -325,6 +326,8 @@ mod time { | |||
| tm_wday: PyObjectRef, | |||
| tm_yday: PyObjectRef, | |||
| tm_isdst: PyObjectRef, | |||
| tm_gmtoff: PyObjectRef, | |||
There was a problem hiding this comment.
okay, now I see what you were talking about in the other pr, I missed this one, sorry!
Yeah, these should be objects here, not options. The distinction between naive/aware is done based on their value (it being None or not), that's what I've understood by quickly looking into this. I'd need some more time to get a better view of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was attempting to solve #4982 but I'm currently stuck with trying to get the timezone abbreviation for the system. any help would be appreciated