Update datetime.py and test_datetime.py to CPYTHON v3.11.2 #5018
Conversation
|
Thanks for the feedback. Do you know why the tests are failing? |
| TESTS = 'test.datetimetester' | ||
|
|
||
| @unittest.skip("TODO: RUSTPYTHON, incorrect datetime struct implementation in time.rs") | ||
| def load_tests(loader, tests, pattern): |
There was a problem hiding this comment.
I don't believe you can skip this. This function is part of the load_tests protocol and generates the test suite to be executed.
If you unskip this what is the error?
There was a problem hiding this comment.
I can take a look later since am on mobile now. There's probably a reason this file wasn't already added.
There was a problem hiding this comment.
when it loads _strptime.py I get an error of no attribute : tzinfo so I guess ill have to fix that before I can add these. On that topic, could you point me in the right direction for creating a field for the time_struct that may of may not be present for a given instance (naive vs timezone aware time struct)
There was a problem hiding this comment.
aha, gotcha. Makes sense to remove this file for now and see how the updates play with the rest of the test suite.
could you point me in the right direction for creating a field for the time_struct that may of may not be present for a given instance
It being an Option seems like the way to go, the docs state it as optional and looking through Python code I'm seeing it being guarded by if tzinfo is None all over the place.
There was a problem hiding this comment.
Do you know how I would go about making it so that when the option is none the python object no longer has that attribute? I still don't fully understand how pystructsequence works.
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
youknowone
force-pushed
the
update_datetime.py
branch
from
12877f9
to
f319633
Compare
I also had to add _strptime.py but test_datetime.py fails due to incorrect datetime struct implementation in time.rs
Contributing to issue :
#4564