Replace jQuery $().toggleClass by vanilla js classList.toggle in sap.ui.unified library #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauriciolauffer
changed the title
|
Hello @mauriciolauffer , |
|
|
mauriciolauffer
force-pushed
the
jquery-toggleclass-sap.ui.unified
branch
from
590b718
to
2f45112
Compare
mauriciolauffer
force-pushed
the
jquery-toggleclass-sap.ui.unified
branch
from
2f45112
to
04e6355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just replacing
jQuery .toggleClassby vanilla jsclassList.toggleinsap.ui.unifiedlibrary. Hopefully more people can help tackling other libraries, then other jQuery features, until we don't have jQuery in the code base anymore.jQuery .toggleClasscan be replaced byclassList.toggleand it's supported by IE11, not just modern browsers.