Correct padding for ObjectPageLayout showing title in header content on display class Desktop-XL #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhuy
changed the title
|
Hi @patrickhuy, |
|
Hi @flovogt, there's already DINC0053067 for the same issue. Shall we close DINC0053713 as a duplicate? |
|
Duplicate DINC0053713 is closed. Thanks for pointing this out @codeworrior |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ObjectPageLayout is set to
showTitleInHeaderContentand the header is displayed with on a screen of classDesktop-XLthe content area (and especially noticeable: the image) don't have a top padding.This can be observed here: https://jsfiddle.net/395hrpye/ (the padding from the icon to top goes away when entering the Desktop-XL layout)
Bildschirmaufnahme.2024-01-30.um.15.12.19.mov
This PR applies the padding from Tablet and Desktop also for Desktop-XL in both the theme "horizon" as well as "quartz".