Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning Umbrella header for module #1131

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix warning Umbrella header for module #1131

wants to merge 2 commits into from

Conversation

wowpotato
Copy link

@wowpotato wowpotato commented Apr 4, 2024 •
edited

When installing SVProgressHUD via sub-framework (also SwiftPM), I received the following warning:

Umbrella header for module 'SVProgressHUD' does not include header 'SVIndefiniteAnimatedView.h'
Umbrella header for module 'SVProgressHUD' does not include header 'SVProgressAnimatedView.h'
Umbrella header for module 'SVProgressHUD' does not include header 'SVRadialGradientLayer.h'

Umbrella header such as 'SVProgressHUD.h' should import these additional headers to resolve the warning.

This fixes that warning.

@honkmaster
@tobihagemann
@juliensaad

@wowpotato
Copy link
Author

@juliensaad Could you please review and merge this pull request as soon as possible? Thank you!

@vectorstofinal
Copy link

vectorstofinal commented May 3, 2024 •
edited

I'm seeing this issue too - but as an error - this PR fixed it for me!

@vectorstofinal vectorstofinal mentioned this pull request May 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wowpotato @vectorstofinal