Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get keyWindow from UIApplication, not AppDelegate. #886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Moriquendi
Copy link

There's no requirement that AppDelegate should have window property. It's how Xcode project is generated by it's not mandatory.
In my case, the app crashes because I hold window somewhere else and SVProgressHUD accesses unavailable selector.

There's no requirement that AppDelegate should have `window` property. It's how Xcode project is generated by it's not mandatory.
@honkmaster
Copy link
Member

We had this solution a few releases / a few years ago. However, we switch to using delegate.window as .keyWindow may not always be the delegate's window, where we want to add the hud. You can search closed issues for this. An option would be to make the window property accessible, with .window as default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants