Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue #837 (accessibility hierarchy problem) (super small PR) #913

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

artem-alexandrov
Copy link

@artem-alexandrov artem-alexandrov commented Jun 11, 2018

Setting parent view as an accessible view prevents from finding siblings, so we need to turn it off if we want to use subviews.
This is crucial for the UI tests since I'm not able to check the message of this HUD if the defaultMaskType set not to none

…ng parent view as an accessible view prevents from finding siblings
@artem-alexandrov artem-alexandrov changed the title Fixed Issue #837 (accessibility hierarchy problem) Fixed Issue #837 (accessibility hierarchy problem) (super small PR) Jun 15, 2018
@artem-alexandrov
Copy link
Author

Anyone?

@honkmaster
Copy link
Member

I can not judge this PR as I am not firm with the accessibility API. Someone else or do you have documentation about the "right" way?

@artem-alexandrov
Copy link
Author

@honkmaster here is the documentation on this property - https://developer.apple.com/documentation/objectivec/nsobject/1615141-isaccessibilityelement
It says if view is a container for other elements which should be accessible, then this property should be false. This is what is needed here to access HUD element and check it's text in UI Tests.

@Selkie972
Copy link

Selkie972 commented Aug 3, 2023

I second the need to fix the accessibility hierarchy, it's painful to test normal errors such as email / password issues without the accessibility change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants