Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first commit for rd #251

Closed
wants to merge 1 commit into from
Closed

first commit for rd #251

wants to merge 1 commit into from

Conversation

emrgnt-cmplxty
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
r2r-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 8:36pm

Copy link

@taahan0810 taahan0810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I left just one review about importing the Pipeline class. Still have to go through the codebase just to be sure.

from ..providers.llm import LLMProvider
from ..providers.logging import LoggingDatabaseConnection, log_execution_to_db
from r2r.core import BasicDocument, GenerationConfig
from r2r.pipelines import Pipeline
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Pipeline class is in .pipeline

Should it be

from .pipeline import Pipeline

@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/extraction-rd branch May 30, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants