Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Porting Classic commands to BiDi in JS #13389

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Jan 3, 2024

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This is POC to demonstrate and act as a foundation for porting Classic commands to BiDi in JS

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani marked this pull request as ready for review January 3, 2024 09:29
@pujagani pujagani marked this pull request as draft January 5, 2024 05:34
@diemol diemol requested a review from harsha509 January 5, 2024 06:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b0ba432) 58.05% compared to head (7ce4ad5) 58.07%.
Report is 27 commits behind head on trunk.

❗ Current head 7ce4ad5 differs from pull request most recent head dfd161b. Consider uploading reports for the commit dfd161b to get more accurate results

Files Patch % Lines
py/selenium/webdriver/firefox/firefox_binary.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #13389      +/-   ##
==========================================
+ Coverage   58.05%   58.07%   +0.01%     
==========================================
  Files          88       88              
  Lines        5338     5340       +2     
  Branches      224      224              
==========================================
+ Hits         3099     3101       +2     
  Misses       2015     2015              
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani pujagani marked this pull request as ready for review January 5, 2024 09:26
Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only minor changes!

javascript/node/selenium-webdriver/firefox.js Outdated Show resolved Hide resolved
javascript/node/selenium-webdriver/index.js Outdated Show resolved Hide resolved
javascript/node/selenium-webdriver/lib/bidiexecutor.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants