-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ladybird: Include scroll bar width/height in viewport rect #24103
Ladybird: Include scroll bar width/height in viewport rect #24103
Conversation
Can you explain what this fixes? Won't this make LibWeb try to paint underneath the scrollbars? |
Practically, I've observed this resolve issues where The viewport rect is also used for
|
Hmm yeah the |
Okay - so it turns out the issue I was having was to do with <style>
body {
margin: 0;
padding: 0;
height: 150vh;
}
#test {
width: 100%;
height: 100vh;
background: url(https://images.placeholders.dev/?width=2200&height=1311&text=WHF!);
background-size: cover !important;
background-position: center !important;
}
</style>
<body>
<div id="test"></div>
</body>
Okay, tangent aside - I'll look into that again another time. Time to start looking into IPC. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
No description provided.