BackgroundPainting: Added a check to compute_text_clip_paths to ensure we are able to produce a path for a given font #24216
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Before this commit Ladybird would crash on websites attempting to utilize the clip-background: text property on a node rendered using a bitmap font
This was the case as
compute_text_clip_paths
assumed the glyph font was a derived instance of typeScaledFont
. In realityBitmapFont
was passed to the function under the above conditionThis commit omits rendering text using the above property for bitmap fonts whilst maintaining it for vector based scaled fonts
This is done by coping the check / error message code from the Gfx library code used when attempting to path-ify bitmap fonts
The optimal solution would be to implement a way for us to calculate outline paths for bitmap fonts however I wanted to reach out and seek some advice of how useful this would be before perusing this.
Test Case: