-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji: Update floppy disk #24239
base: master
Are you sure you want to change the base?
Emoji: Update floppy disk #24239
Conversation
TL;DR Changed the hole/metal protector in floppy disk emoji. Made protector clearer to discern but less accurate. I felt the original emoji was a little confusing with how it portrayed the rectangular hole in the metal protector of the disk: it just looks like a gap, like someone forgot to fill it in. This version changes it so the grey/metal takes up the entire width of the dark blue area, leaving a 2x1 hole. This is less accurate (the hole should be taller than wide) but IMO it makes it clearer that it's, well, a hole, and not empty space between two separate things.
Hello! One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho this is an improvement. I approve of the new emoji design in this PR. :^)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All images and emoji need to be optimized so please run "optipng -strip all" on the emoji.
Also, the buggiebot issues need to be fixed:
"Commit message contains CRLF line breaks (only unix-style LF linebreaks are allowed)
Commit message lines are too long (maximum allowed is 72 characters, except for URLs)"
The commit message could probably be changed to something like:
"Base: Update emoji floppy disk
💾 - U+1F4BE FLOPPY DISK
Change the metal cover for improved legibility."
Seeing people improving our emoji always makes me a little extra happy, so welcome to the project!
I created the commit from github.com, although it was on Windows. I can access a Linux install, but I shouldn't |
Changed the hole/metal protector in floppy disk emoji. Made protector clearer to discern but less accurate.
I felt the original emoji was a little confusing with how it portrays the rectangular hole in the metal protector of the disk: it just looks like a gap, like someone forgot to fill it in.
This version changes it so the grey/metal takes up the entire width of the dark blue area, leaving a 2x1 hole.
This is less accurate to a real 3.5" disk (the hole should be taller than wide) but IMO, it makes it clearer that it's, well, a hole, and not empty space between two separate things.
A potential alternative is this. It's the same as the current emoji but has that missing pixel filled in.