Don't delegate to bulkhead, it might be nil #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalehamel
changed the title
|
We might just want "allow_nil" here, not sure what the best behavior is. |
dalehamel
force-pushed
the
protected-resource-name
branch
from
14426f3
to
6cc3bae
Compare
sirupsen
reviewed
Apr 4, 2017
| @@ -2,15 +2,15 @@ module Semian | |||
| class ProtectedResource | |||
| extend Forwardable | |||
|
|
|||
| def_delegators :@bulkhead, :destroy, :count, :semid, :tickets, :registered_workers, :name | |||
| def_delegators :@circuit_breaker, :reset, :mark_failed, :mark_success, :request_allowed?, | |||
There was a problem hiding this comment.
Shouldn't we do the same if the circuit breaker is disabled?
There was a problem hiding this comment.
Yeah i think both should just do allow_nil.
@sirupsen looks like |
BoGs
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Prevent a nil pointer dereference if attempting to read the name (or any other attribute delegated to bulkhead) of a protected resource without a bulkhead.
Why
Since bulkheads are now optional, we shouldn't delegate anything explicitly to them, as this can result in a nil pointer dereference.
How
The name is attempted to be read from the bulkhead first, falling back to the circuit breaker. If neither works, it will be nil, but it won't cause an exception to be raised from a nil pointer dereference.
Every other attribute has a safe accessor method defined, which will return a default value (same as for an unprotected resource) if there is no bulkhead.