Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use switch-case in ConstraintInsetTarget and constraintOffsetTargetValue will be better? #528

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

guzhenhuaGitHub
Copy link
Contributor

@guzhenhuaGitHub guzhenhuaGitHub commented Aug 7, 2018

replace if-else with switch-case in ConstraintInsetTarget and constraintOffsetTargetValue
before:

if let amount = self as? Float {
...
} else if let amount = self as? Double {
...

change to:

switch self {
case let amount as Float:
...
case let amount as Double:
...
}

will that seems to be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant