Add Drag In and Drag Out events #2198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaved comments in this commit for code review before merge. known isues: - DnD HTML5 API: If drag too fast to another browser UI element (ej. dev tools) the HTML5 DnD dragLeave event is not triggered (not an issue from this code) ... a workaround could be to force a fallback to get the element at pointer position when dragging back to the browser window.
Svelte demoREPL: https://svelte.dev/repl/98f5c00046754b13bd4aae4d362b20e2?version=3.50.0 |
Before: dragIn event was only triggered when it was a valid list to drop in. However if the list was nested in another Sortable the event didn't fire again because it was already marked as valid. After: dragIn event is triggered even if is not a valid Sortable to drop in. Now is up to the Sortable component to handle and check if the list is allowed to drop in.
onDrop event is triggered when a sortable-dragging element is dropped inside the X and Y of the Sortable element, even if there was no onEnd event triggered
|
Nice! |
|
@roy-mdr Is it going to merge in to the main library? How long do we have to wait for it? |
Unfortunately its not my decision but the original developers :/ Hopefully soon! |
|
@owen-m1 Any idea on when it is going to merge? P.S. If there are no core maintainers for this project right now, how about we recruit some? I would love to contribute to this library. |
|
@SyedMSawaid Yeah I'm happy to add you if you'd like to contribute, I don't have a lot of time anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaved comments in this commit for code review before merge.
known isues:
This PR resolve #2075 #979 #460 #1468 #2159 #1269
Usage