Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update A_B.ipynb #161

Open
wants to merge 3 commits into
base: dmarx.ab_notebook
Choose a base branch
from

Conversation

miao-ju
Copy link

@miao-ju miao-ju commented Dec 20, 2022

Allow both staging ad production on different test cases. Unitize'grpc_host‘ and ’host‘

nbs/A_B.ipynb Outdated
@@ -270,6 +261,7 @@
"# not a fan of this name. maybe call this section \"experiments\"?\n",
"differentiators:\n",
" test_case_A:\n",
" host: grpc-staging.stability.ai:443\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure we don't want this endpoint to be the notebook default, since this notebook will be public and I'm pretty sure this endpoint isn't supposed to be. for cases where we want to test against this endpoint, we can distribute an appropriate config file that has it as a test case like this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see. Very thoughtful. Thanks!

Copy link
Contributor

@dmarx dmarx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public notebook should only advertise the prod endpoint.

No staging - external use
@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants