Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FortuneTeller (discovery sample) to work with Steeltoe v4 (main) #328

Merged
merged 2 commits into from
May 16, 2024

Conversation

bart-vmware
Copy link
Member

@bart-vmware bart-vmware commented May 15, 2024

This PR replaces the original FortuneTeller sample (demonstrating Steeltoe Service Discovery) with a new version based on the .NET 8 project templates and works with the latest changes in the Steeltoe main branch (v4).

@bart-vmware bart-vmware marked this pull request as ready for review May 15, 2024 14:05
@bart-vmware bart-vmware requested a review from TimHess May 15, 2024 14:05
Copy link
Member

@TimHess TimHess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM factoring in SteeltoeOSS/Steeltoe#1300

…unchSettings.json

Co-authored-by: Tim Hess <tim.hess@broadcom.com>
@bart-vmware bart-vmware merged commit fd5536a into latest May 16, 2024
0 of 3 checks passed
@bart-vmware bart-vmware deleted the update-discovery-samples branch May 16, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants