Refactoring Parts of Java code #1007
Open
+577
−539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frooodle
requested changes
Apr 1, 2024
| addEndpointToGroup("Javascript", "compare"); | ||
| addEndpointToGroup("Javascript", "adjust-contrast"); | ||
| private void initialize() { | ||
| addEndpointsToGroup( |
There was a problem hiding this comment.
This is cleaner code but I dislike the readability of it, the group name looks like a endpoint here
Perhaps dont use elispe operator and just new a new String[] for each?
Comment on lines
+134
to
+146
| private File createTempFile(MultipartFile multipartFile) throws IOException { | ||
| File tempFile = GeneralUtils.convertMultipartFileToFile(multipartFile); | ||
| tempFile.deleteOnExit(); | ||
| return tempFile; | ||
| } | ||
|
|
||
| private String getMergedFileName(MultipartFile[] files) { | ||
| return files[0].getOriginalFilename().replaceFirst("[.][^.]+$", "") + "_merged.pdf"; | ||
| } | ||
|
|
||
| private void cleanupTempFiles(List<File> tempFiles) { | ||
| for (File file : tempFiles) { | ||
| file.delete(); |
There was a problem hiding this comment.
I feel like these are all operations that could fit within the Util class and used elsewhere if needed?
| pagesToCheck = pagesToCheck.replaceAll("\\s+", ""); | ||
|
|
||
| String[] splitPoints = pagesToCheck.split(","); | ||
| for (String splitPoint : splitPoints) { | ||
| if (splitPoint.contains("-")) { | ||
| // Handle page ranges |
There was a problem hiding this comment.
Why the removal of comments here? what smell was this?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hello
This is Akash. I am using your repo for learning more about Code smells. I was able to identify some in some of the documents.
I did some changes and refactored the codes. Hope you go through them and make the necessary changes in the main.
Thanking you in advance
AKASH
Checklist:
Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)