Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance UI Search Functionality in Navbar #1199

Merged
merged 5 commits into from May 12, 2024

Conversation

jimdouk
Copy link
Contributor

@jimdouk jimdouk commented May 12, 2024

Description

This pull request addresses the open issue regarding the "Search Functionality on Navbar". Collaborating with @foivospro, we've implemented several improvements to enhance the user experience:

  • Improved Search Bar Behavior:
    Implemented an if statement to prevent displaying results when the search bar is empty, ensuring a cleaner UI.

  • Enhanced Result Display:
    Removed unnecessary padding from the search results, providing a more streamlined appearance.

  • Standardized Search Bar Width:
    Set a standard width for the search bar, ensuring consistent sizing across different devices and screen resolutions.

Please provide a summary of the changes, including relevant motivation and context.

Closes #1076

Checklist:

  • [x ] I have read the Contribution Guidelines
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [x ] My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

@jimdouk jimdouk requested a review from Frooodle as a code owner May 12, 2024 13:31
@Frooodle Frooodle merged commit f2b7aee into Stirling-Tools:main May 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search Functionality on Navbar
2 participants