Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework OCR file handling #840

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thomas-mc-work
Copy link

Description

This PR reflects the ideas discussed in #300.

In detail this is:

  • replace the copy process around the OCR language files by a decoupled approach based on soft links
  • decoupling: separation of custom files and system files
  • get rid of the copy processes (takes less resources)
  • reduces image size (takes less resources)
  • simplifies the process for the user (also make it more robust)
  • additional: improved the language package installation (replace a loop by a single command)

Checklist:

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Contributor License Agreement

By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.

(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

I'm happy to hear your thoughts about this!

@thomas-mc-work
Copy link
Author

Also solves #511

HowToUseOCR.md Outdated Show resolved Hide resolved
@thomas-mc-work thomas-mc-work changed the title rework OCR file handling WIP: rework OCR file handling Feb 22, 2024
@thomas-mc-work thomas-mc-work changed the title WIP: rework OCR file handling Rework OCR file handling Feb 26, 2024
Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thomas-mc-work
Copy link
Author

WDYT?

@thomas-mc-work
Copy link
Author

If you find the change to be too breaking, you might consider pushing the version number to 1.0 along with some other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants