Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TopBottomPresentable): Adds 'TopBottomPresentable' protocol, allow any Animator to be presented correctly by the Presenter #548

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lifely
Copy link

@lifely lifely commented Apr 24, 2024

The current implementation of Presenter check for a topBottomStyle using TopBottomAnimation.Style enum which allow during install to present the Message over or under navigation-bar and tab-bar.

However the current implementation of the topBottomStyle computed property limit all customisation of behaviour and only allow presentation in .top or .bottom style with the TopBottomAnimation animator.

I've implemented a simple TopBottomPresentable protocol which return the TopBottomAnimation.Style? behaviour needed; thus we can add conformance of this protocol to our existing TopBottomAnimation and PhysicsAnimation.

This would allow customisation in any Animator in the futur by simple conforming to TopBottomPresentable.

Hope this is convenient for other people as well and can make it in, I'll be available if you need any change or need to drop the last commit (podspecs & version change for my own use atm)

…conformance on existing 'Animators' to allow '.top/.bottom' presentation w/ PhysicsAnimator
@wtmoose
Copy link
Member

wtmoose commented Apr 25, 2024

Seems like a good improvement. I’ll try to get to this soon, but I’m super busy right now

@lifely
Copy link
Author

lifely commented Apr 26, 2024

no worry @wtmoose we all know how busyness can get 🐝

If you need anything done just holla @ me 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants