replaceExisting to append query parameters and delete all query paramters #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tospery
commented
Apr 27, 2024
tospery
commented
- Add replaceExisting to appendingQueryParameters/appendQueryParameters.
- Add deletingAllQueryParameters/deleteAllQueryParameters methods support.
| } | ||
|
|
||
| func testAppendQueryParameters() { | ||
| url.appendQueryParameters(params) | ||
| XCTAssertEqual(url, queryUrl) | ||
| let replaceURL = URL(string: "https://www.google.com?q=swift%20swifter")! | ||
| replaceURL.appendQueryParameters(params, replaceExisting: true) | ||
| XCTAssertEqual(replaceURL, queryUrl) |
There was a problem hiding this comment.
Can we add a test where there is an additional param added as well, only this q param makes function seem a no-op.
Comment on lines
130
to
133
| /// | ||
| /// var url = URL(string: "https://domain.com?query=true")! | ||
| /// url.deleteAllQueryParameters() | ||
| /// print(url) // prints "https://domain.com" |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// var url = URL(string: "https://domain.com?query=true")! | |
| /// url.deleteAllQueryParameters() | |
| /// print(url) // prints "https://domain.com" | |
| /// | |
| /// var url = URL(string: "https://domain.com?query=true")! | |
| /// url.deleteAllQueryParameters() | |
| /// print(url) // prints "https://domain.com" |
LucianoPAlmeida
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.