Fixes #1041 and #1038 on linux variants

[monomadic]

Compilation fails due to tighter type restrictions on newer swift builds. Casting works and produces no errors. See #1041 and #1038 for complaints on this issue.

• Does this have tests?
  Unnecessary, existing tests cover this case (it is purely a type definition in two places)
• Does this have documentation?
  Not needed
• Does this break the public API (Requires major version bump)?
  No
• Is this a new feature (Requires minor version bump)?
  No

[diskshima]

@deathdisco Shouldn't this be < (instead of >)?
(Should explain for the failing tests 😉 )

[eritbh]

Any movement here? I'm developing a cross-platform library that depends on SwiftyJSON and having this fixed would be a huge benefit!

[diskshima]

@monomadic This isn't compiling (at least on a mac).

I think the Swift compiler thinks < is part of a Generic statement and is erroring with

❌  /Users/travis/build/SwiftyJSON/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift:1215:79: expected '>' to complete generic argument list

    case (.number, .number): return lhs.rawNumber as NSNumber < rhs.rawNumber as NSNumber
                                                              ^

on Travis CI here.

You need to put brackets around the left side of <.

    case (.number, .number): return (lhs.rawNumber as NSNumber) < rhs.rawNumber as NSNumber
                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Need brackets

[eritbh]

After applying that fix on a local checkout of this branch under Ubuntu 18.04 in WSL 2, it still doesn't work. I've changed the line to:

    case (.number, .number): return (lhs.rawNumber as NSNumber) < (rhs.rawNumber as NSNumber)

When adding the local copy as a dependency of another project and running swift test on that project, I get the following error:

% swift test
/home/george/Code/monomadic/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift:1215:65: error: ambiguous use of operator '<'
    case (.number, .number): return (lhs.rawNumber as NSNumber) < (rhs.rawNumber as NSNumber)
                                                                ^
/home/george/Code/monomadic/SwiftyJSON/Source/SwiftyJSON/SwiftyJSON.swift:1251:6: note: found this candidate
func < (lhs: NSNumber, rhs: NSNumber) -> Bool {
     ^
Foundation.NSNumber:2:24: note: found this candidate
    public static func < (lhs: NSNumber, rhs: NSNumber) -> Bool

It seems there's a deeper issue that this PR doesn't address at all. Is it possible that this is a bug in the Linux implementation of Foundation?

[diskshima]

@Geo1088 Yeah, you're right. Sorry jumped the gun a bit.

The quick fix might be to rename the operators like this.
The build passes on macOS and Linux but the tests still gives errors around INT64_MAX and autoreleasepool on Linux (tested on a Docker instance based on Ubuntu 18) and obviously may not be the right way to fix it.

[seriyvolk83]

Consider #1083 instead.

[LinusGeffarth]

Any update on this? Seeing this error still