[Admin] Footer #16210

Rafikooo · 2024-05-02T16:48:12Z

Q	A
Branch?	2.0
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	no
License	MIT

github-actions · 2024-05-02T17:46:20Z

Bunnyshell Preview Environment deployment failed

Check https://github.com/Sylius/Sylius/actions/runs/8937830979 for details.

Available commands:

/bns:deploy to redeploy the environment
/bns:delete to remove the environment

Rafikooo · 2024-05-03T10:48:38Z

src/Sylius/Bundle/AdminBundle/Resources/views/Shared/Crud/Common/Content/footer.html.twig

+                <ul class="list-inline list-inline-dots m-1">
+                    <li class="list-inline-item">
+                        <a href="https://docs.sylius.com/en/1.13" target="_blank" class="link-secondary" rel="noopener">
+                            Stable Documentation


I wasn't sure if we should also include translations for these new texts, so I decided to leave it for comments.

…lek, NoResponseMate, GSadee, jakubtobiasz, Wojdylak, kulczy, Rafikooo, mpysiak) This PR was merged into the 2.0 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 2.0 | Bug fix? | no | New feature? |yes | BC breaks? | yes | Deprecations? | no | Related tickets | | License | MIT As our new Bootstrap Admin Panel is already mostly covered and starting to be functional, I would like to merge branch `bootstrap-admin-panel` to `2.0` and continue the work here.  Commits ------- c046fb7 Use extension instead of changing the existing forms in ProductBundle 38c8be5 minor review fixes 115d4c2 Revoke change of AutocompleteChoiceType to AdminBundle's one 10a2cc5 move ProductType related extensions definitions to dedicated file 165b84c Bring back the transformer from ProductBundle and create a new one for Admin eff1c8f Use ProductAssociationType instead of extension 2310f81 [Admin][DX] Remove autocompleters 480cfca [Admin][Product] Add ProductAttribute autocomplete type 9516ad0 [Admin][DX] Change `AutocompleteChoiceType` suffix to `AutocompleteType` 72411ad [Admin][DX] Add default aliases to autocomplete fields 6e256e6 [Admin][UX] Add more searchable fields to autocompletes e694fbd Merge branch '2.0' into bootstrap-admin-panel 6b26f4a Add the "sylius.live_component" tag and the translation layer 04fc430 Move all components from the "TwigComponent" directory under the "Twig\Component" directory c2f0596 Convert all AsLiveComponent attribute to the custom sylius.live_component tag 8823b74 Bump ux-symfony packages minimal version 32e2cca Update PHPStan ignore rules for Twig components ce811f2 Fix the malformed sylius_admin:country:form component usages 2fd9297 Fix not adding the 'controller.service_arguments' tag to services tagged with sylius.live_component 1e30fb3 Bring back #[AsLiveComponent] attribute to LiveComponent classes 65969a7 Unfinalize all components 7be88ea Rename `TaxonTreeComponent` component to `TreeComponent` 7e52dfa Fix Product's Form component service id e435ebf Rename `ShipComponent` to `ShipFormComponent` ed65c29 Adjust the Zone's form component to the new standard 3d06429 [Behat] Change mink panther to chromedriver bf3a434 Rename sylius_admin:order:history:address to sylius_admin:order:addresshistory 6f3c0d9 [Behat] Disable behat test 73b4a5f Unify index actions 4cc8549 Add show buttons to the homepage 064db37 Improve filter section 5e319d4 Make bolder header d3748e9 Style grid fields templates 4e6f42d Improve grids view 7d37d78 Fix tests 5fd5746 [Admin][Zone] Move FormComponent 8b6d2b1 [Admin][Zone] Move FormComponent (Sylius#16256) 32fcf43 [Admin][Product][Inventory] Enable behat tests 08c3e85 [Admin][Taxon] Implements media management 630f9a1 [Admin][Taxon][Image] Enable behat tests e6deeb4 [Behat] Submit live component before submitting the form e3909ab [Behat] Extract waitForFormUpdate function to CrudFormElement 59695b1 [Taxon][Behat] Extract management of image to separate form element. 554da08 [Admin][Taxon] Remove unnecessary code e30e391 [Admin][Taxon] Split media more granularly f42496c [Admin][Taxon] Rename FormImageElement to ImageFormElement 36e06c0 Merge branch '2.0' into bootstrap-admin-panel bb4e9f3 [Admin][UI] Add error indicators for form tabs and accordions 865a481 Review fixes d1ed503 Remove final from the Zone's form component e6bd06a Remove final from the Zone's form component (Sylius#16270) cb9ac59 [Admin][UI] Add error indicators for form tabs and accordions (Sylius#16263) 27a9529 [Admin][Product] Add view in store button d8e1758 [Admin][Product] Enable and fix tests f7378ae Changes after CR c940afe Merge branch '2.0' into bootstrap-admin-panel a313b14 Fixes after CR 6d6079e minor Sylius#16268 [Admin][Product] Add view in store button (mpysiak) 68da42b [Maintenance] Enable non-UI tests in CI 71ff79c [Behat] Add possibility to accepting null as value in response checker f083d82 [Admin][UX] Filter translatable autocomplete results based on current locale

…hook configs

GSadee · 2024-05-20T09:30:01Z

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "footer" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

GSadee · 2024-05-21T11:49:34Z

src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/common/create.yaml

@@ -17,6 +17,9 @@ twig_hooks:
                template: '@SyliusAdmin/shared/crud/create/content/form.html.twig'
                configuration:
                    render_rest: true
+            footer:
+                template: '@SyliusAdmin/shared/crud/common/content/footer.html.twig'
+                priority: -100


We will add priorities to all the hooks at the end of the work on the BAP

GSadee · 2024-05-21T11:51:17Z

src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/footer.html.twig

+                    <li class="list-inline-item">
+                        Copyright © 2024
+                        <a href="https://sylius.com/" target="_blank" class="link-secondary">Sylius</a>.
+                        All rights reserved.


We should add all texts as translations

GSadee · 2024-05-21T11:51:50Z

src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/footer.html.twig

+            <div class="col-lg-12 ms-lg-auto">
+                <ul class="list-inline list-inline-dots m-1">
+                    <li class="list-inline-item">
+                        <a href="https://docs.sylius.com/en/1.13" target="_blank" class="link-secondary" rel="noopener">


Suggested change

<a href="https://docs.sylius.com/en/1.13" target="_blank" class="link-secondary" rel="noopener">

<a href="https://docs.sylius.com" target="_blank" class="link-secondary" rel="noopener">

GSadee · 2024-05-21T11:52:58Z

src/Sylius/Bundle/AdminBundle/templates/shared/crud/common/content/footer.html.twig

+                    <li class="list-inline-item">
+                        <a href="https://new-docs.sylius.com" target="_blank" class="link-secondary" rel="noopener">
+                            New Documentation (Work in Progress)
+                        </a>
+                    </li>


Suggested change

<li class="list-inline-item">

<a href="https://new-docs.sylius.com" target="_blank" class="link-secondary" rel="noopener">

New Documentation (Work in Progress)

</a>

</li>

I would be for not referring to this documentation for now

Rafikooo requested review from a team as code owners May 2, 2024 16:48

probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label May 2, 2024

Rafikooo force-pushed the footer branch from 79e44f2 to 0a2cf20 Compare May 2, 2024 16:50

Rafikooo force-pushed the footer branch from 0a2cf20 to 71c243e Compare May 3, 2024 10:46

Rafikooo commented May 3, 2024

View reviewed changes

Rafikooo force-pushed the footer branch 2 times, most recently from 354fe48 to 92d265a Compare May 6, 2024 12:38

GSadee and others added 5 commits May 20, 2024 11:25

[Admin] Add footer template

ffbbfa3

[Admin] Include footer hookable in default crud content hooks

4a0477f

[Admin] Include custom footer hookable in variant generation hook config

59973c5

[Admin] Set explicit priorities for footer hookable in default views …

817a318

…hook configs

GSadee changed the base branch from bootstrap-admin-panel to 2.0 May 20, 2024 09:30

GSadee force-pushed the footer branch from 92d265a to 817a318 Compare May 20, 2024 09:30

GSadee reviewed May 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Admin] Footer #16210

[Admin] Footer #16210

Rafikooo commented May 2, 2024 •

edited

github-actions bot commented May 2, 2024 •

edited

Rafikooo May 3, 2024

GSadee commented May 20, 2024

GSadee May 21, 2024

GSadee May 21, 2024

GSadee May 21, 2024

GSadee May 21, 2024

	<a href="https://docs.sylius.com/en/1.13" target="_blank" class="link-secondary" rel="noopener">
	<a href="https://docs.sylius.com" target="_blank" class="link-secondary" rel="noopener">

[Admin] Footer #16210

Are you sure you want to change the base?

[Admin] Footer #16210

Conversation

Rafikooo commented May 2, 2024 • edited

github-actions bot commented May 2, 2024 • edited

Bunnyshell Preview Environment deployment failed

Rafikooo May 3, 2024

Choose a reason for hiding this comment

GSadee commented May 20, 2024

GSadee May 21, 2024

Choose a reason for hiding this comment

GSadee May 21, 2024

Choose a reason for hiding this comment

GSadee May 21, 2024

Choose a reason for hiding this comment

GSadee May 21, 2024

Choose a reason for hiding this comment

Rafikooo commented May 2, 2024 •

edited

github-actions bot commented May 2, 2024 •

edited