Unify Twig & Live components #16221
Merged
Unify Twig & Live components #16221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
probot-autolabeler
bot
added
the
Maintenance
jakubtobiasz
force-pushed
the
unify-components
branch
4 times, most recently
from
c57df67
to
016b882
Compare
Wojdylak
approved these changes
May 7, 2024
src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component.xml
Outdated
Show resolved
Hide resolved
NoResponseMate
approved these changes
May 8, 2024
src/Sylius/Bundle/AdminBundle/Twig/Component/Shipment/ShipComponent.php
Outdated
Show resolved
Hide resolved
jakubtobiasz
force-pushed
the
unify-components
branch
from
016b882
to
de8aa1e
Compare
|
I've rebased the PR, and applied all suggestions c:. |
…g\Component" directory
…ged with sylius.live_component
Wojdylak
force-pushed
the
unify-components
branch
from
bb520a1
to
2df6635
Compare
Wojdylak
reviewed
May 13, 2024
src/Sylius/Bundle/AdminBundle/Resources/config/services/twig/component.xml
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
May 13, 2024
Wojdylak
added a commit
that referenced
this pull request
May 17, 2024
| Q | A |-----------------|----- | Branch? | bootstrap-admin-panel <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | License | MIT <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> To be consisted with the rest of changes in #16221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:convention applied, so every component is named likesylius_admin:some:component, so it can be used like<twig:sylius_admin:some:component />in Twig templatessylius.live_componentshortcut tag has been added