Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify index actions #16234

Merged

Conversation

kulczy
Copy link
Member

@kulczy kulczy commented May 8, 2024

Screenshot 2024-05-13 at 13 26 21 Screenshot 2024-05-13 at 13 26 47 Screenshot 2024-05-13 at 13 27 38 Screenshot 2024-05-13 at 13 27 25 Screenshot 2024-05-13 at 13 29 06 Screenshot 2024-05-13 at 13 28 54 Screenshot 2024-05-13 at 13 28 38 Screenshot 2024-05-13 at 13 28 24 Screenshot 2024-05-13 at 13 28 13 Screenshot 2024-05-13 at 13 28 00 Screenshot 2024-05-13 at 13 27 45

@kulczy kulczy requested review from a team as code owners May 8, 2024 14:04
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label May 8, 2024
Copy link

github-actions bot commented May 8, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@kulczy kulczy force-pushed the bootstrap-admin-panel-index-actions branch 3 times, most recently from df3086d to d0d76b1 Compare May 13, 2024 11:46
@kulczy kulczy changed the title [WIP] Unify index actions Unify index actions May 13, 2024
@kulczy kulczy force-pushed the bootstrap-admin-panel-index-actions branch from 0b5e80c to 0924701 Compare May 13, 2024 13:19
@GSadee
Copy link
Member

GSadee commented May 14, 2024

/bns:deploy

@@ -5,7 +5,7 @@ imports:
- { resource: "@SyliusAdminBundle/Resources/config/app/sylius/sylius_mailer.yml" }
- { resource: "@SyliusAdminBundle/Resources/config/grids/address_log_entry.yml" }
- { resource: "@SyliusAdminBundle/Resources/config/grids/admin_user.yml" }
- { resource: "@SyliusAdminBundle/Resources/config/grids/catalog_promotion.yaml" }
- { resource: "@SyliusAdminBundle/Resources/config/grids/catalog_promotion.yml" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be for using .yaml instead of .yml, so not changing this one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this and the next file be moved to AdminBundle?

@GSadee GSadee merged commit 7d37d78 into Sylius:bootstrap-admin-panel May 14, 2024
19 checks passed
@kulczy kulczy deleted the bootstrap-admin-panel-index-actions branch May 14, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants