Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPMERGE] 2.0 -> bootstrap-admin-panel #16250

Merged
merged 36 commits into from May 13, 2024

Conversation

SyliusBot
Copy link

This PR has been generated automatically.
For more details see upmerge_pr.yaml.

Remember! The upmerge should always be merged with using Merge pull request button.

In case of conflicts, please resolve them manually with usign the following commands:

git fetch upstream
gh pr checkout <this-pr-number>
git merge upstream/bootstrap-admin-panel -m "Resolve conflicts between 2.0 and bootstrap-admin-panel"

If you use other name for the upstream remote, please replace upstream with the name of your remote pointing to the Sylius/Sylius repository.

Once the conflicts are resolved, please run git merge --continue and push the changes to this PR.

Wojdylak and others added 30 commits May 8, 2024 10:26
This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.12
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | n/a
| License         | MIT

Fixes CVE-2024-29376. Reported here: https://github.com/r2tunes/Reports/blob/main/Sylius.md


Commits
-------

0a7fe9e Add js sanitizeInput function
89880cd Add sanitizer function to UIBundle
19cea9a Use function from UIBundle
3d66fb0 [AddressBook] Add scenario for preventing from a potential XSS attack
9255540 [Checkout] Add scenario for preventing from a potential XSS attack
30de6ff [Behat] Minor scenarios improvements after code review
This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.12
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | n/a
| License         | MIT

Fixes potential xss in admin panel (Taxons and Products)

Commits
-------

d4812f9 Fix potential xss in admin panel
29d18a3 Use function from UIBundle
c11c424 Fix product-auto-complete
a17de6d Test adding new taxon
d25edf3 Test adding new simple product
63c3cf7 Test adding similar products
679e793 Fixes after CR
…ress Book and Admin Panel (GSadee)

This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.12
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

This PR aims to solve 2 issues:

- Potential Cross Site Scripting (XSS) via the "Province" field in the Checkout and Address Book (https://github.com/r2tunes/Reports/blob/main/Sylius.md)
- Potential Cross Site Scripting (XSS) via the "Name" field (Taxons, Products, Options, Variants) in the Admin Panel


Commits
-------
  Fix potential xss in admin panel
  Use function from UIBundle
  Fix product-auto-complete
  Add js sanitizeInput function
  Add sanitizer function to UIBundle
  Use function from UIBundle
  [AddressBook] Add scenario for preventing from a potential XSS attack
  [Checkout] Add scenario for preventing from a potential XSS attack
  [Behat] Minor scenarios improvements after code review
  Test adding new taxon
  Test adding new simple product
  Test adding similar products
  Fixes after CR
  bug #69 Fix potential xss in AdressBook and Checkout (mpysiak, GSadee)
  bug #76 Fix potential xss in admin panel (mpysiak)
  [Behat] Minor scenarios improvements
This PR was merged into the 1.12 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.12
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | N/A
| License         | MIT


Commits
-------

6ca4a6a [Maintenance] Update docker docs
3fa947e [Maintenance] Remove unnecessary line
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.13
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | N/A
| License         | MIT

Hello, 

I wanted to add a library, but I got stuck with the deprecation-contract, the library I wanted only accept `^3.0`

As we can see on the [diff](symfony/deprecation-contracts@2.5...3.4), there is not so much change between the two version.

I think we can add that version too without changing anything else.

Tell me if I should target `1.12` instead. 

Thanks 


Commits
-------

ac1d727 Add wider support for deprecation contract
* 1.12:
  [Behat] Minor scenarios improvements
  Fixes after CR
  Test adding similar products
  Test adding new simple product
  Test adding new taxon
  [Behat] Minor scenarios improvements after code review
  [Checkout] Add scenario for preventing from a potential XSS attack
  [AddressBook] Add scenario for preventing from a potential XSS attack
  Use function from UIBundle
  Add sanitizer function to UIBundle
  Add js sanitizeInput function
  Fix product-auto-complete
  Use function from UIBundle
  Fix potential xss in admin panel
  [Maintenance] Remove unnecessary line
  [Maintenance] Update docker docs
* 1.13:
  [Behat] Minor scenarios improvements
  Fixes after CR
  Test adding similar products
  Test adding new simple product
  Test adding new taxon
  [Behat] Minor scenarios improvements after code review
  [Checkout] Add scenario for preventing from a potential XSS attack
  [AddressBook] Add scenario for preventing from a potential XSS attack
  Use function from UIBundle
  Add sanitizer function to UIBundle
  Add js sanitizeInput function
  Fix product-auto-complete
  Use function from UIBundle
  Fix potential xss in admin panel
  Add wider support for deprecation contract
  [Maintenance] Remove unnecessary line
  [Maintenance] Update docker docs
* 1.14:
  [Behat] Minor scenarios improvements
  Fixes after CR
  Test adding similar products
  Test adding new simple product
  Test adding new taxon
  [Behat] Minor scenarios improvements after code review
  [Checkout] Add scenario for preventing from a potential XSS attack
  [AddressBook] Add scenario for preventing from a potential XSS attack
  Use function from UIBundle
  Add sanitizer function to UIBundle
  Add js sanitizeInput function
  Fix product-auto-complete
  Use function from UIBundle
  Fix potential xss in admin panel
  Add wider support for deprecation contract
  [Maintenance] Remove unnecessary line
  [Maintenance] Update docker docs
* 1.12:
  Change application's version to v1.12.17-dev
  Generate changelog for v1.12.16
  Change application's version to v1.12.16
* 1.13:
  Change application's version to v1.12.17-dev
  Generate changelog for v1.12.16
  Change application's version to v1.12.16
* 1.14:
  Change application's version to v1.12.17-dev
  Generate changelog for v1.12.16
  Change application's version to v1.12.16
* 1.13:
  Change application's version to v1.13.2-dev
  Generate changelog for v1.13.1
  Change application's version to v1.13.1
* 1.14:
  Change application's version to v1.13.2-dev
  Generate changelog for v1.13.1
  Change application's version to v1.13.1
@SyliusBot SyliusBot requested review from a team as code owners May 11, 2024 02:11
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Shop ShopBundle related issues and PRs. labels May 11, 2024
@GSadee GSadee merged commit 8659346 into bootstrap-admin-panel May 13, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants