Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed depreciated inspect function #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icfly2
Copy link

@icfly2 icfly2 commented Dec 9, 2020

getfullargspec is a drop in replacement for getargspec, see docs for details

`getfullargspec` is a drop in replacement for `getargspec`, see https://docs.python.org/3/library/inspect.html#inspect.getargspec for details
@codecov-io
Copy link

Codecov Report

Merging #396 (fca6d57) into master (017c738) will decrease coverage by 17.25%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #396       +/-   ##
===========================================
- Coverage   97.32%   80.07%   -17.26%     
===========================================
  Files          49       49               
  Lines        3142     3142               
  Branches      585      585               
===========================================
- Hits         3058     2516      -542     
- Misses         44      581      +537     
- Partials       40       45        +5     
Impacted Files Coverage Δ
eli5/base_utils.py 90.00% <100.00%> (-10.00%) ⬇️
eli5/keras/gradcam.py 0.00% <0.00%> (-100.00%) ⬇️
eli5/xgboost.py 4.26% <0.00%> (-95.13%) ⬇️
eli5/formatters/image.py 5.47% <0.00%> (-94.53%) ⬇️
eli5/keras/explain_prediction.py 4.81% <0.00%> (-91.57%) ⬇️
eli5/lightgbm.py 4.27% <0.00%> (-90.60%) ⬇️
eli5/catboost.py 11.53% <0.00%> (-88.47%) ⬇️
eli5/_decision_path.py 35.48% <0.00%> (-64.52%) ⬇️
eli5/keras/__init__.py 50.00% <0.00%> (-50.00%) ⬇️
eli5/ipython.py 85.71% <0.00%> (-14.29%) ⬇️
... and 12 more

@icfly2
Copy link
Author

icfly2 commented Dec 10, 2020

Surely this is due to a change in tests not related to this PR

@lopuhin
Copy link
Contributor

lopuhin commented Feb 10, 2021

Thanks you! This were merged in eli5-org/eli5#2 and released to PyPI with v0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants