Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update heap_sort.c #619

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Update heap_sort.c #619

wants to merge 7 commits into from

Conversation

Shwetik
Copy link
Contributor

@Shwetik Shwetik commented Sep 30, 2020 •
edited by gitpod-io bot

Description of Change

Added time complexities of functions used.

  • Relevant documentation/comments is changed or added

@Shwetik
Update heap_sort.c
60a69ec 
Added time complexities of functions used.
@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 30, 2020
Shwetik
Shwetik commented Sep 30, 2020
View reviewed changes
Copy link
Contributor Author

@Shwetik Shwetik left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please follow latest update

Shwetik
Shwetik commented Sep 30, 2020
View reviewed changes
Copy link
Contributor Author

@Shwetik Shwetik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated hep_sort.c

Panquesito7
Panquesito7 previously approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work. 👍 😄

sorting/heap_sort.c Outdated Show resolved Hide resolved
sorting/heap_sort.c Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added Admin views requested Requesting opinions from Maintainers and Admins of the repo. approved Approved; waiting for merge labels Sep 30, 2020
Shwetik and others added 2 commits October 1, 2020 05:08
@Shwetik @Panquesito7
Update sorting/heap_sort.c
43087d6 
Co-authored-by: David Leal <halfpacho@gmail.com>
@Shwetik @Panquesito7
Update sorting/heap_sort.c
bf40819 
Co-authored-by: David Leal <halfpacho@gmail.com>
@kvedala
Copy link
Collaborator

kvedala commented Oct 1, 2020 •
edited

Thank you @Shezza221b
However, the documentation will not be compiled and not be visible until the code is updated to the specs. Please refer to contribution guidelines for a sample program structure.
Please update the other related pull-requests as well.

@kvedala kvedala mentioned this pull request Oct 1, 2020
Open
1 task
realstealthninja
realstealthninja suggested changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

void heapsort needs documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@realstealthninja realstealthninja realstealthninja requested changes

@Panquesito7 Panquesito7 Panquesito7 left review comments

@kvedala kvedala Awaiting requested review from kvedala

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Admin views requested Requesting opinions from Maintainers and Admins of the repo. approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shwetik @kvedala @Panquesito7 @realstealthninja