Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/consolidated reverse letters and reverse long words #10107

Closed
wants to merge 4 commits into from
Closed

Fix/consolidated reverse letters and reverse long words #10107

wants to merge 4 commits into from

Conversation

AnshuSharma111
Copy link
Contributor

Describe your change:

Deleted reverse_long_words.py and modified code of reverse_letters.py to integrate functionality of reverse_long_words.py. Both had almost same function of reversing the letters of words in a sentence without reversing the words.

  1. Deleted reverse_long_words.py
  2. Implemented its functionality to reverse_letters.py because both had same function
  3. Changed Directory.md to reflect changes

Fixes #8098

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 8, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 8, 2023
@@ -1,19 +1,22 @@
def reverse_letters(input_str: str) -> str:
def reverse_letters(sentence: str, length: int) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def reverse_letters(sentence: str, length: int) -> str:
def reverse_letters(sentence: str, length: int = 0) -> str:

Let's make the length an optional parameter so that we can still preserve the same functionality as the original reverse_letters

Please also add a test case for length = 0

@AnshuSharma111 AnshuSharma111 closed this by deleting the head repository Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concatenate/consolidate all algorithms with different implementations
2 participants