Add Van der Waals equation of state #11359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Van-der-Waals equation of state for gasses
cclauss
requested changes
Apr 19, 2024
| """ | ||
|
|
||
| if temperature < 0 or volume < 0: | ||
| raise ValueError("Please provide the positive values") |
There was a problem hiding this comment.
Suggested change
| raise ValueError("Please provide the positive values") | |
| raise ValueError("Please provide non-negative values") |
There was a problem hiding this comment.
Please add a test for both values being zero.
|
|
||
|
|
||
| def system_pressure( | ||
| quantity: float, temperature: float, volume: float, a: float, b: float |
There was a problem hiding this comment.
Please replace a and b with self-documentating variable names.
There was a problem hiding this comment.
What happens when quantity is zero? When quantity is negative?
| return 1 / (quantity * R) * (pressure + a / volume**2) * (volume - quantity * b) | ||
|
|
||
|
|
||
| def critical_temperature(a: float, b: float) -> float: |
There was a problem hiding this comment.
Single letter variable names went out of style in the 1970’s.
| """ | ||
|
|
||
| if pressure < 0 or volume < 0: | ||
| raise ValueError("Please provide the positive values") |
| 154.3865270378366 | ||
| """ | ||
|
|
||
| return 8 * a / (27 * b * R) |
There was a problem hiding this comment.
Please replace b & R with self-documentating names
algorithms-keeper
bot
added
the
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist: