-
-
Notifications
You must be signed in to change notification settings - Fork 43.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated simple_neural_network.py #9569
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation is definitely a far improvement over our current implementation (and it runs much faster!), but you really shouldn't just copy the implementation from your source. However, I think it's fine if you significantly refactor it to make it more of your own work. @cclauss, thoughts?
One example of how you could rewrite and improve your replacement implementation is to write a class for the neural network: then initialize_network
would just be the __init__
function and training would all fall under a NN object's methods. This would allow the user to create a NN and not have to pass the object into the training function.
There is no software license associated with:
I think we should keep the current I am not a fan of replacing other people's work with a copy of yet another person's work without some work to create value. If serious work is done to add type hints, doctests, etc. to the functions then this could considered a derivative work. However, given there is no license, I think we would need approval from @jbrownlee or @Jason2Brownlee before we land this in an MIT-licensed repo. https://github.com/TheAlgorithms/Python/blob/master/LICENSE.md |
Sorry, I no longer own or operate machine Learning mastery - I cannot comment on licenses for the code. I recommend that you reach out to the company directly. That being said, I wrote it as a port of my 2011 ruby version which is under creative commons here: There are tons of algorithms there that may interest you for this project. |
->Created simple_neural_network.py from scratch
->It now contains Forward propagation as well as backward propagation
with training of the simple 2 layer neural network.
->Article Referred is a free resource avialable for evryone
Fixes #8785
Checklist:
simple_neural_network.py
is member-only #8785 ".