Feat : Coin-Change #201
Open
Feat : Coin-Change #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
requested changes
Oct 15, 2023
dynamic_programming/coin_change.ts
Outdated
| * Calculates the number of ways to make a target amount using given coin denominations. | ||
| * | ||
| * @param coins - An array of coin denominations. | ||
| * @param numCoins - The number of different coin denominations. |
There was a problem hiding this comment.
Why this parameter? Seems redundant with coins.length.
| */ | ||
| export function coinChange(coins: number[], numCoins: number, targetAmount: number): number { | ||
|
|
||
| const dp: number[] = new Array(targetAmount + 1).fill(0); |
There was a problem hiding this comment.
Please give this a more fitting name, such as numberOfWays, or simply ways, something in that direction, which characterizes what dp[i] stores (the number of ways to represent i using the coins).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coin Change problem implementation using Tabulation DP
Hi @raklaptudirm @appgurueu please review this PR