Added support for negative numbers in digit_sum() #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
reviewed
Mar 26, 2024
There was a problem hiding this comment.
Could be just num = Math.abs(num);. The doc comment would also need to be updated to say "an integer".
I don't think this is necessarily an improvement, though. It makes sense to only allow natural numbers. People can simply do digitSum(Math.abs(k)) if they want to apply it to negative numbers as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function digit_sum() check if the number provided is integer or not. if not then check if the number is negative or not. if negative then make it positive and proceed for the sum.