each google subdomain can have(?) or has it's own email and password #183
Conversation
| @@ -109,6 +109,38 @@ func (handler *Handler) updateDNS(domain *settings.Domain, ip string) error { | |||
| } | |||
| } | |||
| } | |||
| for _, designated := range domain.DelegatedSubDomains { | |||
There was a problem hiding this comment.
May I know what does the DelegatedSubDomains used for?
There was a problem hiding this comment.
If so, this part of the code is only available for the Google handler?
There was a problem hiding this comment.
I don't think it is needed to check the other providers. I'm just not sure if this change will affect the other providers. For example, is the config DelegatedSubDomains compulsory? Or for the other providers can just ignore it from the config file?
|
A DelegatedSubDomain has its own 'email' and password, instead of using the
'email' and password of the domain. If a server is somehow compromised,
only the subdomains delegated to that server are exposed. See the config
file I'm using below in my minikube godns cconfig.
{
"provider": "Google",
"domains": [{
"domain_name": "<domain>",
"delegated_sub_domains": [
{
"domain_name": "<subdomain1>",
"email": "<email1>",
"password": "<pass1>"
},
{
"email": "<email2>",
"password": "<pass2>",
"domain_name": "<subdomain2>"
}
]
}
],
"resolver": "8.8.8.8",
"ip_url": "https://api.ipify.org",
"ip_type": "IPv4",
"interval": 300,
"socks5_proxy": ""
}
…On Fri, Aug 26, 2022 at 11:31 AM Timothy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In internal/handler/handler.go
<#183 (comment)>:
> @@ -109,6 +109,38 @@ func (handler *Handler) updateDNS(domain *settings.Domain, ip string) error {
}
}
}
+ for _, designated := range domain.DelegatedSubDomains {
May I know what does the DelegatedSubDomains used for?
—
Reply to this email directly, view it on GitHub
<#183 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARQAHVFXSADREXD3CMPTTBTV3DPOJANCNFSM57E7IKMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I don't know what the other handlers support. I have a Google account, so
that is what I focused on.
I'm happy to check out the other providers you think it's useful.
…On Sat, Aug 27, 2022, 12:00 Timothy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In internal/handler/handler.go
<#183 (comment)>:
> @@ -109,6 +109,38 @@ func (handler *Handler) updateDNS(domain *settings.Domain, ip string) error {
}
}
}
+ for _, designated := range domain.DelegatedSubDomains {
If so, this part of the code is only available for the Google handler?
—
Reply to this email directly, view it on GitHub
<#183 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARQAHVB3ILFOAVYFRKDRKN3V3I3THANCNFSM57E7IKMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I only changed the config handler for google, which now accepts either
configuration. (see internal/utils/settings.go). If other providers support
this configuration I would move the either/or check into its own function.
…On Sat, Aug 27, 2022 at 2:03 PM Timothy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In internal/handler/handler.go
<#183 (comment)>:
> @@ -109,6 +109,38 @@ func (handler *Handler) updateDNS(domain *settings.Domain, ip string) error {
}
}
}
+ for _, designated := range domain.DelegatedSubDomains {
I think no need to check the other providers. I'm not sure if this change
will affect the other providers. For example, is the config
DelegatedSubDomains compulsory? Or for the other providers can just
ignore it from the config file?
—
Reply to this email directly, view it on GitHub
<#183 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARQAHVF7BKAYEETSEVVWGPTV3JJ5JANCNFSM57E7IKMQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
OK, let me test the compatibility. |
No description provided.