#2335 Add support for session properties in model defaults #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add support for session properties in model defaults TobikoData#2335
|
|
izeigerman
reviewed
May 12, 2024
izeigerman
reviewed
May 12, 2024
izeigerman
reviewed
May 12, 2024
|
Make sure to run |
izeigerman
reviewed
May 12, 2024
| @@ -2698,6 +2698,47 @@ def test_model_table_properties_conflicts() -> None: | |||
| sql_model.physical_properties | |||
|
|
|||
|
|
|||
| def test_session_properties_on_model_and_project(sushi_context): | |||
There was a problem hiding this comment.
Let's also add a test when there are only defaults but nothing is set in the model definition.
izeigerman
reviewed
May 12, 2024
izeigerman
reviewed
May 12, 2024
izeigerman
reviewed
May 12, 2024
| } | ||
|
|
||
|
|
||
| def test_project_level_session_properties(sushi_context): |
There was a problem hiding this comment.
Thanks for adding this test! Since you caught an edge case which involved a Python model would it make sense to add a test which tests specifically the dict route?
izeigerman
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow you to set session_properties on the project configuration which will then be propagated on the models. If custom properties are also set on the specific model, those will not be overwritten by the default ones. It might need some more work when adding the default props to handle quoted/unquoted identifiers better; right now, it sets them by default as quoted=False.