Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: pages sidebar collapsable and pin functionality in preview/release mode #9650

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Feature: pages sidebar collapsable and pin functionality in preview/release mode #9650

wants to merge 4 commits into from

Conversation

vjaris42
Copy link
Collaborator

@vjaris42 vjaris42 commented May 8, 2024

Resolves: #9290

  • Ability to pin pages sidebar
  • Ability to expand/collapse pages sidebar to utilise the available space

@vjaris42 vjaris42 self-assigned this May 8, 2024
@johnsoncherian
Copy link
Collaborator

Pinning a menu once unpinned is difficult. Can we extend the onhover event to the pin button too

Screen.Recording.2024-05-09.at.10.25.04.AM.mov

@johnsoncherian
Copy link
Collaborator

The menu reset to pinned status once even if you have unpinned post reload

@vjaris42 vjaris42 linked an issue May 9, 2024 that may be closed by this pull request
Implement collapsible page menu function in App builder #9290
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Deployment: https://tooljet-pr-9650.onrender.com
Dashboard: https://dashboard.render.com/web/srv-cou7gp0l5elc73c6r390

johnsoncherian
johnsoncherian previously approved these changes May 15, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

Deployment: https://tooljet-pr-9650.onrender.com
Dashboard: https://dashboard.render.com/web/null

@github-actions GitHub Actions
Copy link

Deployment: https://tooljet-pr-9650.onrender.com
Dashboard: https://dashboard.render.com/web/null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsoncherian johnsoncherian johnsoncherian left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@vjaris42 vjaris42

Labels
suspend-review-app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement collapsible page menu function in App builder
3 participants
@vjaris42 @johnsoncherian @akshaysasidrn