Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing foreign key constraint on app import #9661

Open
wants to merge 7 commits into
base: release/database-1.1.1
Choose a base branch
from

Conversation

shaurya-sharma064
Copy link
Collaborator

@shaurya-sharma064 shaurya-sharma064 commented May 9, 2024

closes: #9695

Problem:
Importing the app breaks the foreign key constraints in the table.

Fix:
Created foreign keys separately after the creation of tables as keys were not forming due to the sequence of table creation. Had to use a bunch of inner transactions in the process.

@CLAassistant
Copy link

CLAassistant commented May 9, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shaurya-sharma064
❌ Shaurya Sharma


Shaurya Sharma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shaurya-sharma064 shaurya-sharma064 changed the base branch from release/database-1.1 to release/database-1.1.1 May 16, 2024 07:35
@shaurya-sharma064 shaurya-sharma064 added this to the Database 1.1.1 milestone May 16, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TJDB: As a user, I should be able to import applications and tables with its foreign keys created
3 participants