Docker Compose CORS fixes (misconfigured env vars) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lued is attempting to deploy a commit to the Tracecat Team on Vercel. A member of the Team first needs to authorize it. |
topher-lo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
CORS changes should be fixing #118.
Docker networking issues should be resolved by fixing environment variable usage for frontend and backend API should fix #117, #49, #40.
Really not networking specific, just fixing missing environment variables.
What does this implement/fix? Explain your changes.
Getting docker compose files functional without host.docker.interal and remove hotfixes in the codebase.
Any other comments?
Made a change to production db.py's sslmode which I could not figure out regarding fqdns. I figure you guys have more information on the usage.
Since there are no formal test cases, I tested most things, but recommend you guys do your testing.