Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cookbook): "Advanced Animations" cookbook recipe #586

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

DennisSmuda
Copy link
Contributor

@DennisSmuda DennisSmuda commented Mar 12, 2024

Closes #477

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit d4ff229
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/663ba4242a8ed5000841ba20
😎 Deploy Preview https://deploy-preview-586--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andretchen0

This comment was marked as outdated.

Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Non-blocking)

Noticed a small spelling mistake, so I thought I'd flag it:

goning

going


Thanks for working on this. It'll be great to have it!

@alvarosabu
Copy link
Member

Thanks @DennisSmuda for creating this PR and the base for multiple languages 💚. Really looking forward for this one.

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DennisSmuda we would like to have this merge, could you please apply the suggestion and convert the PR to ready to review?

docs/cookbook/advanced-animations.md Outdated Show resolved Hide resolved
@DennisSmuda DennisSmuda marked this pull request as ready for review April 4, 2024 17:47
@DennisSmuda DennisSmuda dismissed alvarosabu’s stale review April 4, 2024 17:48

did the changes :)

@DennisSmuda
Copy link
Contributor Author

Hey @alvarosabu sorry I had trouble getting to it 🗡️

English + German looks good to me now 👍

@andretchen0
Copy link
Contributor

Oh, hey! Will review soon!

Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! A few small changes.

The long comment is non-blocking, so feel free to ignore or just take the useful-to-you bits.

docs/cookbook/advanced-animations.md Outdated Show resolved Hide resolved
docs/public/recipes/advanced-animations.png Outdated Show resolved Hide resolved
docs/public/recipes/advanced-animations.png Outdated Show resolved Hide resolved
docs/public/recipes/advanced-animations.png Outdated Show resolved Hide resolved
@DennisSmuda
Copy link
Contributor Author

@andretchen0 I updated with your suggestions - thanks again ❤️

Also updated the screenshot for the overview:
Screenshot 2024-04-23 at 23 17 08

@DennisSmuda DennisSmuda dismissed andretchen0’s stale review April 23, 2024 21:18

thanks for taking a look

Copy link
Contributor

@andretchen0 andretchen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@alvarosabu : ready to merge?

@DennisSmuda
Copy link
Contributor Author

DennisSmuda commented Apr 26, 2024

Looks good to me! 👍

@alvarosabu : ready to merge?

I only did german + english. I could remove the recipe from the other languages first, or generate some content with ChatGPT 😄

@enpitsuLin
Copy link
Collaborator

enpitsuLin commented Apr 28, 2024

Great work! I'm also a big fan of GSAP and I think there are many people should want to known how to make GASP work with Tres.

@DennisSmuda I can review Chinese part if u want translate to other languages by LLM, or I can raise a PR for Chinese after this be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] - Advance animations using gsap
4 participants