-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts/Spells: Implemented Priest talent Sanctuary #29727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work at all, nothing about these spells do any sort of damage prevention
so just by applying the aura on target doesn't mean is gonna work right? |
I mean the spell passes the info correctly to the aura, but the aura itself is SPELL_AURA_DUMMY, it won't do much on itself besides showing the correct numbers on the client. |
Also, the spell that does the absorb is Mind Blast - 208771. Ignore the name, they didn't care about renaming it. You need an AuraScript for this to calculate its amount based on the actor's damage done. |
if (caster->HasAura(SPELL_PRIEST_SANCTUARY)) | ||
{ | ||
caster->CastSpell(GetHitUnit(), SPELL_PRIEST_SANCTUARY_AURA, true); | ||
caster->CastSpell(caster, SPELL_PRIEST_SANCTUARY_ABSORB, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you choosing caster as target? The one holding the aura should be the target of smite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from sniffs it looks like both target and caster get an aura, 208771 on caster(like a hidden one, from which the absorb happens) and 208772 on target
…into Sanctuary
Issues addressed:
Sanctuary doesn't work. Smite should apply on target an aura that prevents x damage dealt by enemy.
Closes # (insert issue tracker number)
200d8ac
Tests performed:
tested ingame
discipline talent
build: BAQA0Hr2WRGgVq7/s2iQ2HhjlABopgg0SCiIlokkEJJBAAAAAAAAAAAItgkEkCRSiIQJEJRUIA