Util Contract #470
Open
Util Contract #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivianjeng
requested changes
May 31, 2023
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
vimwitch
requested changes
Jun 1, 2023
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
vivianjeng
reviewed
Jun 26, 2023
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
vimwitch
requested changes
Jun 27, 2023
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
packages/contracts/contracts/attester-utils/ReimburseAttestation.sol
Outdated
Show resolved
Hide resolved
vivianjeng
requested changes
Jul 21, 2023
| ) public payable virtual { | ||
| require(whitelist[msg.sender], 'This user is not in the whitelist'); | ||
|
|
||
| uint256 attesterSignalIndex = unirep.numEpochKeyNoncePerEpoch(); |
There was a problem hiding this comment.
the signal index is not numEpochKeyNoncePerEpoch
just hardcode like uint256 attesterSignalIndex = 2;
Comment on lines
+10
to
+14
| uint8 public immutable numEpochKeyNoncePerEpoch; | ||
|
|
||
| constructor() { | ||
| numEpochKeyNoncePerEpoch = 2; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
yarn build) was run locally in root directory and any changes were pushedyarn lint:fix) was run locally in root directory and any changes were pushedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information