feat: refactor data usage into hooks, estimate monthly added fees #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
nunogois
reviewed
May 17, 2024
| })); | ||
|
|
||
| const StyledCardTitleRow = styled(Box)(() => ({})); |
nunogois
reviewed
May 17, 2024
| }: INetworkTrafficUsagePlanSummary) => { | ||
| const overages = usageTotal - includedTraffic; | ||
| const estimateFlagEnabled = useUiFlag('estimateTrafficDataCost'); | ||
| console.log(estimateFlagEnabled); |
nunogois
reviewed
May 17, 2024
| requests | ||
| </Badge> | ||
| } | ||
| /> |
There was a problem hiding this comment.
Why not something like:
<Badge color={usageTotal <= includedTraffic ? 'success' : 'error'}>
{usageTotal.toLocaleString()}{' '}
requests
</Badge>
nunogois
reviewed
May 17, 2024
| } | ||
| elseShow={ | ||
| <Badge color='error'> | ||
| <Badge color='neutral'> | ||
| {usageTotal.toLocaleString()}{' '} | ||
| requests | ||
| </Badge> | ||
| } | ||
| /> |
There was a problem hiding this comment.
Add 'neutral' to the ternary as well and you can get rid of this other conditional render with the repeated badge 😄
nunogois
reviewed
May 17, 2024
| </StyledGrid> | ||
| } | ||
| /> | ||
| </StyledContainerGrid> |
There was a problem hiding this comment.
Might just be me, but from a design perspective it's a bit weird to me that some of these are badges but not others. At least I don't follow the reasoning. I recommend double checking with @FredrikOseberg just in case.
nunogois
reviewed
May 17, 2024
frontend/src/hooks/useTrafficData.ts
Outdated
| import type { ChartDataset } from 'chart.js'; | ||
|
|
||
| const trafficDataUnitCost = 5; | ||
| const trafficDataUnitSize = 1_000_000; |
There was a problem hiding this comment.
I don't think we're super strict with this, but we generally identify constants like these with UPPER_SNAKE_CASE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes