Skip to content

Commit

Permalink
fix: set skip_infer_tables explicitly in `test_partition_via_api_wi…
Browse files Browse the repository at this point in the history
…th_no_strategy` (#3057)

### Summary

A `partition_via_api` test that only runs on `main` was
[failing](https://github.com/Unstructured-IO/unstructured/actions/runs/9159429513/job/25181600959)
with the following output, likely due to the change in the default
behavior for `skip_infer_table_types`. This PR explicitly sets the
`skip_infer_table_types` param to avoid the failure..

```python
=========================== short test summary info ============================
FAILED test_unstructured/partition/test_api.py::test_partition_via_api_with_no_strategy - AssertionError: assert 'Zejiang Shen® (<), Ruochen Zhang?, Melissa Dell®, Benjamin Charles Germain Lee?, Jacob Carlson®, and Weining Li®' != 'Zejiang Shen® (<), Ruochen Zhang?, Melissa Dell®, Benjamin Charles Germain Lee?, Jacob Carlson®, and Weining Li®'
 +  where 'Zejiang Shen® (<), Ruochen Zhang?, Melissa Dell®, Benjamin Charles Germain Lee?, Jacob Carlson®, and Weining Li®' = <unstructured.documents.elements.Text object at 0x7fb9069fc610>.text
 +  and   'Zejiang Shen® (<), Ruochen Zhang?, Melissa Dell®, Benjamin Charles Germain Lee?, Jacob Carlson®, and Weining Li®' = <unstructured.documents.elements.Text object at 0x7fb90648ad90>.text
= 1 failed, 2299 passed, 9 skipped, 2 deselected, 2 xfailed, 9 xpassed, 14 warnings in 1241.64s (0:20:41) =
make: *** [Makefile:302: test] Error 1
```

### Testing

After temporarily removing the "skip if not on `main`" `pytest` mark,
the [unit tests
pass](https://github.com/Unstructured-IO/unstructured/actions/runs/9163268381/job/25192040902?pr=3057O)
on the feature branch.
  • Loading branch information
MthwRobinson committed May 20, 2024
1 parent 6066a26 commit acda4d0
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test_unstructured/partition/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,11 @@ def test_partition_via_api_with_no_strategy():
filename=filename,
strategy="auto",
api_key=get_api_key(),
skip_infer_table_types=["pdf"],
)
elements_hi_res = partition_via_api(
filename=filename, strategy="hi_res", api_key=get_api_key(), skip_infer_table_types=["pdf"]
)
elements_hi_res = partition_via_api(filename=filename, strategy="hi_res", api_key=get_api_key())

# confirm that hi_res strategy was not passed as default to partition by comparing outputs
# elements_hi_res[3].text =
Expand Down

0 comments on commit acda4d0

Please sign in to comment.