Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add read and combine json #2691

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

preemware
Copy link

For review.

@ron-unstructured
Copy link
Contributor

read_and_combine_json function is used in the "Multi-files API Processing" example in the documentation

@preemware
Copy link
Author

preemware commented Mar 25, 2024

I made a mistake. I believe the intent of the function was to return as a Iterable[dict[str, Any]]. I can make this change.

@preemware
Copy link
Author

preemware commented Mar 25, 2024

Referencing the original documentation. The intent appears to have it return as Iterable[dict[str, Any]] into dict_to_elements. If it returned as just a list, the code might not work as intended.

combined_json_data = read_and_combine_json("Connector-Output/world-development-bank-2023")
elements = dict_to_elements(combined_json_data)
chunks = chunk_by_title(elements)

Copy link
Contributor

@ron-unstructured ron-unstructured left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MthwRobinson
Copy link
Contributor

@preemware - Are you still working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants