-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Indexing options for Astra DB columns #2919
Closed
erichare
wants to merge
14
commits into
Unstructured-IO:main
from
erichare:feat/astra-db-indexing-options
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c814b55
FEAT: Support Indexing options for Astra DB columns
erichare 35a84ea
FIX lint check
erichare 527ea09
Pass the namespace param
erichare d194b08
Use pre-referenced collection name var
erichare 7ed3c3a
Set the separator to an underscore for metadata fields
erichare ee4a5ed
Deny indexing on full metadata by default
erichare 3df6417
Ruff check fix
erichare 4976fb0
FIX: no default for the options for compat with other integrations
erichare 275674b
Merge branch 'main' into feat/astra-db-indexing-options
erichare 9c87fec
Clean up initialization based on feedback
erichare acc2edb
Merge branch 'main' into feat/astra-db-indexing-options
erichare 66bee62
Update indexing policy type and provide example
erichare 78350a2
Merge branch 'main' into feat/astra-db-indexing-options
erichare d302e7b
Remove mistaken venv commit
erichare File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you want them exposed to the cli, namespace and requested_indexing_policy need to be added to
https://github.com/Unstructured-IO/unstructured/blob/main/unstructured/ingest/cli/cmds/astra.py
Which will also be helpful since they will have some documentation there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! i tried to match the data model to the "required" option for the CLI, hopefully this looks good.