Favor upsert over add + use element_id to prevent duplicates #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make chroma etl pipeline idempotent :)
|
@0xjgv Thanks for this! And thanks for alerting me. Great idea. I will bring it up to the team. |
|
Thanks for the PR! I do agree with the upsert. I had doubts on assigning the element id, however based on the last state of id calculation, collisions don't seem to be likely. Looks good to me, needs to pass ingest tests. |
|
@ahmetmeleq @0xjgv can you see any downsides to doing it this way? (seems like it is a good idea all aound) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make chroma ingest pipeline idempotent :)
@potter-potter